[PATCH] [PPC64] Add 64-bit Vector Integer Arithmetic Instructions

[Eric Christopher]

On Tue, Mar 3, 2015 at 11:58 AM Kit Barton <kbarton at ca.ibm.com> wrote:

> Committed revision 231115.
>
>
> ================
> Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:578
> @@ -577,3 +577,3 @@
>        // VSX v2i64 only supports non-arithmetic operations.
> -      setOperationAction(ISD::ADD, MVT::v2i64, Expand);
> -      setOperationAction(ISD::SUB, MVT::v2i64, Expand);
> +      if (! Subtarget.hasP8Altivec()) {
> +        setOperationAction(ISD::ADD, MVT::v2i64, Expand);
> ----------------
> echristo wrote:
> > Whitespace.
> Is this in reference to the space between ! and Subtarget?
>

Yep.


> I fixed this just now, so it will be in the next diff or the patch that I
> checkin if no other diffs are required.
>
>
Two things:

a) should get used to using clang-format on your patches. Means you don't
have to worry about formatting sections of code you write.
b) Just commit it by itself, we try not to fold things in that way.

Thanks!

-eric


> http://reviews.llvm.org/D7959
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150303/80ef0a56/attachment.html>