[PATCH] Add logical ops to Mips fast-isel

Eric Christopher echristo at gmail.com
Tue Mar 3 11:29:24 PST 2015


Haven't looked at the contents of the testcases past the general stuff, but this looks much better.

One inline comment.

-eric


================
Comment at: test/CodeGen/Mips/Fast-ISel/logopm.ll:582
@@ +581,3 @@
+; CHECK:        addu    $[[REG_GP:[0-9]+]], $[[REG_GPb]], $25
+; CHECK-DAG:    lw      $[[US_ADDR:[0-9]+]], %got(us)($[[REG_GP]])
+; CHECK-DAG:    lw      $[[US1_ADDR:[0-9]+]], %got(us1)($[[REG_GP]])
----------------
Any reason for the CHECK-DAG here? Are you seeing ordering issues between mips32 and mip32r2 here?

http://reviews.llvm.org/D6599

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list