[PATCH] [RewriteStatepointsForGC] Fix a relocation bug w.r.t values defined by invoke instructions

Chen Li meloli87 at gmail.com
Mon Mar 2 21:26:51 PST 2015


Hi Philip, 
I don't have commit access. Please help me submit it. Thanks!


================
Comment at: lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:1572
@@ +1571,3 @@
+               InvokeInst which is handled above.");
+         store->insertAfter(cast<Instruction>(def));
+      }
----------------
sanjoy wrote:
> You have an `isa<Instruction>(def)` followed by two `cast<Instruction>(def)`s.  It might just be better to `dyn_cast` to an `Instruction` in the condition like you've done for the `InvokeInst`.
Yes, I will clean up this part.

http://reviews.llvm.org/D7923

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list