[PATCH] During PHI elimination, split critical edges that move copies out of loops

Matthias Braun matze at braunis.de
Mon Mar 2 16:47:21 PST 2015

In http://reviews.llvm.org/D8016#133116, @MatzeB wrote:

> The change itself LGTM (but nitpick below).
> As mentioned in by you on IRC we perform some unlucky choices in the coalescing order in test/CodeGen/X86/coalescer-commute4.ll with this patch. Are there more? If it's just some tests like this failing but benchmarks generally improving, then it's okay to XFAIL the tests, or trying to rewrite them in a way that we are lucky with the heuristic. If benchmarks generally regress with the changes, then we need further research on how to avoid that...

You answered to most of my remarks while I was writing this :)



More information about the llvm-commits mailing list