[PATCH] This patch introduces MemorySSA, a virtual SSA form for memory.Details on what it looks like are in MemorySSA.h

David Majnemer david.majnemer at gmail.com
Sun Mar 1 20:07:44 PST 2015


================
Comment at: include/llvm/Analysis/AliasAnalysis.h:155-156
@@ +154,4 @@
+      return getLocation(I);
+    else
+      llvm_unreachable("unsupported memory instruction");
+  }
----------------
No need for else here.

================
Comment at: include/llvm/Transforms/Utils/MemorySSA.h:1-2
@@ +1,3 @@
+//===- MemorySSA.h - Build Memory SSA ----------------------------*- C++
+//-*-===//
+//
----------------
This looks strange, can you make it look like the other files?

================
Comment at: lib/Transforms/Utils/MemorySSA.cpp:1
@@ +1,2 @@
+
+//===- MemorySSA.cpp - Memory SSA Builder----------------------------------===//
----------------
No need for this whitespace.

http://reviews.llvm.org/D7864

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list