[compiler-rt] r230256 - [asan] when registering globals, use the same unwinder as we use for malloc, instead of the one used for FATAL crash (which may be too slow)

Kostya Serebryany kcc at google.com
Wed Feb 25 08:50:04 PST 2015


On Wed, Feb 25, 2015 at 8:41 AM, Renato Golin <renato.golin at linaro.org>
wrote:

> On 25 February 2015 at 16:25, Kostya Serebryany <kcc at google.com> wrote:
> > And we can disable the test on ARM for now to make the bot green
>
> Disabling tests is the last resort, and I don't want to do that unless
> it's really *meant* to fail on ARM (like TSAN on 32-bits).
>
> I don't think this investigation will be quick enough, as we're
> already 2 days in the red. Since the patch is not very big and we're
> far from another release code-freeze, I think the prudent thing to do
> would be to revert and investigate.
>
>
This will break *our* release cycle. Please don't revert.




> I appreciate that in the past it used to be an Intel thing only, but
> as projects mature, we have to care for a wider audience.
>
> I'll create a bug for it and assign to myself, so we can track this issue.
>
> cheers,
> --renato
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150225/fa51e7bd/attachment.html>


More information about the llvm-commits mailing list