[PATCH] asan: do not instrument direct inbounds accesses to stack variables

[Dmitry Vyukov]

On Wed, Feb 25, 2015 at 5:16 AM, Kostya Serebryany <kcc at google.com> wrote:
> ================
> Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:189
> @@ -184,1 +188,3 @@
> +       cl::desc("Don't instrument scalar stack variables"), cl::Hidden,
> +       cl::init(true));
>
> ----------------
> zaks.anna wrote:
>> This makes me nervous. I don't think ObjectSizeOffsetEvaluator is used much. This should probably go through more testing, though I am not sure how to catch issues here since we are removing checking.
> ouch. Indeed, don't make it true by default for now.
> Unfortunately, I don't know any good way to test complex optimizations that eliminate checks,
> and so I don't know what it will take us to enable this by default.
> But at least having this code in trunk will simplify the experiments.


Can we run it on all reproducible bugs from ClusterFuzz? That would be
a good measure.