[PATCH] [clang][Driver][MCTargetOptions]Change clang driver to adopt new definition of createAsmBackend

Eric Christopher echristo at gmail.com
Fri Feb 20 09:54:55 PST 2015


On Fri Feb 20 2015 at 6:10:02 AM Vladimir Medic <Vladimir.Medic at imgtec.com>
wrote:

> ================
> Comment at: tools/driver/cc1as_main.cpp:358
> @@ -357,2 +357,3 @@
>        TheTarget->createMCSubtargetInfo(Opts.Triple, Opts.CPU, FS));
> +  MCTargetOptions Options = InitMCTargetOptionsFromFlags();
>
> ----------------
> echristo wrote:
> > I'd prefer not to do this, clang already has its own option handling.
> Ideas on how to avoid this?
> Not right now, at least not a simple one. The FIXME comment that was
> removed said:"init MCTargetOptions from sanitizer flags here." So we should
> probably need to map clang options to MCTargetOptions.
>
>
I think we should do that.

In particular here you should map the -mabi option.

Thanks!

-eric


> http://reviews.llvm.org/D7747
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150220/9b8b4205/attachment.html>


More information about the llvm-commits mailing list