[PATCH] Don't set $LIB if we're not targetting windows.

Timur Iskhodzhanov timurrrr at google.com
Fri Feb 20 07:51:10 PST 2015


LGTM with a nit


================
Comment at: test/lit.common.cfg:64
@@ -63,2 +63,3 @@
 # Help MSVS link.exe find the standard libraries.
-if platform.system() == 'Windows':
+# Make sure we only try to use it when targetting Windows
+if platform.system() == 'Windows' and '-win' in config.target_triple:
----------------
nit: please end the sentence with a period:
`# Make sure we only try to use it when targetting Windows.`

http://reviews.llvm.org/D7739

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list