[PATCH] Add logical ops to Mips fast-isel

Eric Christopher echristo at gmail.com
Thu Feb 19 21:28:54 PST 2015

Couple of inline comments.

Probably want to clean up the testcase a bit (though I know you've said you're working on it).


Comment at: lib/Target/Mips/MipsFastISel.cpp:466
@@ -423,1 +465,3 @@
+bool MipsFastISel::isTypeSupported(Type *Ty, MVT &VT, bool IsVectorAllowed) {
+  if (Ty->isVectorTy() && !IsVectorAllowed)
You never pass true for IsVectorAllowed, it's just dead so remove it.

Comment at: test/CodeGen/Mips/Fast-ISel/logopm.ll:1
@@ +1,2 @@
+; RUN: llc -march=mipsel -relocation-model=pic -O0 -mips-fast-isel -fast-isel-abort -mcpu=mips32r2 \
+; RUN:     < %s | FileCheck %s
If you're going to line wrap then you should do it at 80-columns, this is just silly. :)



More information about the llvm-commits mailing list