[PATCH] [PPC64] Fix problem with commutability of VORC instruction

[Kit Barton]

Hi hfinkel, wschmidt, seurer, nemanjai,

I incorrectly marked the VORC instruction as isCommutable when I added it. 
This fix removes the VORC instruction definition from the isCommutable block.

http://reviews.llvm.org/D7772

Files:
  lib/Target/PowerPC/PPCInstrAltivec.td
  test/CodeGen/PowerPC/vec_veqv_vnand_vorc.ll

Index: lib/Target/PowerPC/PPCInstrAltivec.td
===================================================================
--- lib/Target/PowerPC/PPCInstrAltivec.td
+++ lib/Target/PowerPC/PPCInstrAltivec.td
@@ -986,9 +986,10 @@
 def VNAND : VXForm_1<1412, (outs vrrc:$vD), (ins vrrc:$vA, vrrc:$vB),
                      "vnand $vD, $vA, $vB", IIC_VecGeneral,
                      [(set v4i32:$vD, (vnot_ppc (and v4i32:$vA, v4i32:$vB)))]>;
+} // isCommutable
+
 def VORC : VXForm_1<1348, (outs vrrc:$vD), (ins vrrc:$vA, vrrc:$vB),
                       "vorc $vD, $vA, $vB", IIC_VecGeneral,
                       [(set v4i32:$vD, (or v4i32:$vA,
                                            (vnot_ppc v4i32:$vB)))]>;
-} // isCommutable
 } // end HasP8Altivec
Index: test/CodeGen/PowerPC/vec_veqv_vnand_vorc.ll
===================================================================
--- test/CodeGen/PowerPC/vec_veqv_vnand_vorc.ll
+++ test/CodeGen/PowerPC/vec_veqv_vnand_vorc.ll
@@ -17,10 +17,13 @@
 ; CHECK: vnand 2, 2, 3
 }
 
-; Test x vorc y
+; Test x vorc y and variants
 define <4 x i32> @test_vorc(<4 x i32> %x, <4 x i32> %y) nounwind {
-       %tmp = xor <4 x i32> %y, <i32 -1, i32 -1, i32 -1, i32 -1>
-       %ret_val = or <4 x i32> %x, %tmp
-       ret <4 x i32> %ret_val
-; CHECK: vorc 2, 2, 3      
+       %tmp1 = xor <4 x i32> %y, <i32 -1, i32 -1, i32 -1, i32 -1>
+       %tmp2 = or <4 x i32> %x, %tmp1
+; CHECK: vorc 3, 2, 3      
+       %tmp3 = xor <4 x i32> %tmp2, <i32 -1, i32 -1, i32 -1, i32 -1>
+       %tmp4 = or <4 x i32> %tmp3, %x
+; CHECK: vorc 2, 2, 3
+       ret <4 x i32> %tmp4
 }

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7772.20343.patch
Type: text/x-patch
Size: 1594 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150219/f10f3c83/attachment.bin>