[PATCH] Don't set $LIB if we're not targetting windows.

Timur Iskhodzhanov timurrrr at google.com
Thu Feb 19 09:21:39 PST 2015


>
> The comment came with my private code. But I don't feel strongly about it.


I see.


> The thing is: we might be running on Windows, but targeting a different
> OS. In which case we don't want to pass LIB along. Your toolchain runs on
> Windows, but you're compiling for arch-vendor-anotheros.
>

I'm not sure how cross-compilation of tests works in LLVM.
Do we ever invoke LIT for anything that we can't run on the current system?


> Wouldn't lld on Windows also look at LIB if it was emulating link.exe (I
> don't know if there's a mode for that, like for emulating ld)?
>

Good point, I'm pretty sure LLD would need LIB to be set too.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150219/cb5d8152/attachment.html>


More information about the llvm-commits mailing list