[PATCH] Don't set $LIB if we're not targetting windows.

Timur Iskhodzhanov timurrrr at google.com
Thu Feb 19 04:48:42 PST 2015

Of course we do use MSVC link.exe to link ASan tests.
LLD is not ready for ASan on Windows as it doesn't produce debug info.

Comment at: test/lit.common.cfg:64
@@ -63,2 +63,3 @@
 # Help MSVS link.exe find the standard libraries.
-if platform.system() == 'Windows':
+# Make sure we only try to use it when targetting Windows
+if platform.system() == 'Windows' and config.target_triple.endswith('win32'):
I don't understand the comment and how it is related to the change in the code.

You've probably meant to write the condition meaning `"if MSVC:"` ?
If so, I don't think you need an extra comment:
  # On Windows, help MSVS link.exe find the standard libraries.
  if platform.system() == 'Windows' and ...:

Deferring the condition to Reid and Hans who know the triples better.



More information about the llvm-commits mailing list