[lld] r229314 - Update ARM and x86 ArchHandler to check switch completeness. NFC

Jean-Daniel Dupas devlists at shadowlab.org
Thu Feb 19 04:42:39 PST 2015


You’re right. I did change the typenames to match other lld enum: Remove the underscore and don’t use plural form. (r229848)

Thanks for the comment.

> Le 18 févr. 2015 à 00:07, Rui Ueyama <ruiu at google.com> a écrit :
> 
> Nitpicky, but the mix of camel case and underscore (Arm_Kinds) looks odd. Can we rename ArmKinds?
> 
> On Sun, Feb 15, 2015 at 7:23 AM, Jean-Daniel Dupas <devlists at shadowlab.org> wrote:
> Author: jddupas
> Date: Sun Feb 15 09:23:48 2015
> New Revision: 229314
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=229314&view=rev
> Log:
> Update ARM and x86 ArchHandler to check switch completeness. NFC
> 
> Define an explicit type for arch specific reference kinds to make sure all cases are covered in switch statements.
> 
> 
> Modified:
>     lld/trunk/lib/ReaderWriter/MachO/ArchHandler_arm.cpp
>     lld/trunk/lib/ReaderWriter/MachO/ArchHandler_x86.cpp
>     lld/trunk/lib/ReaderWriter/MachO/ArchHandler_x86_64.cpp





More information about the llvm-commits mailing list