[PATCH] Introduce bitset metadata format and bitset lowering pass.

Peter Collingbourne peter at pcc.me.uk
Wed Feb 18 18:45:11 PST 2015


================
Comment at: lib/Transforms/IPO/LowerBitSets.cpp:189
@@ +188,3 @@
+
+BitSetInfo LowerBitSets::buildBitSet(
+    MDString *BitSet,
----------------
kcc wrote:
> I would add comments for every non-trivial function.
> In most cases, I understand what these things are doing, other readers (including myself in 6 months) will probably be puzzled. 
Done

================
Comment at: lib/Transforms/IPO/LowerBitSets.cpp:292
@@ +291,3 @@
+  Value *Bit;
+  if (BSI.Bits.size() <= 8) {
+    // If the bit set is sufficiently small, we can avoid a load by bit testing
----------------
kcc wrote:
> split into a separate function? 
Done

http://reviews.llvm.org/D7288

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list