[PATCH] Use ScalarEvolution to create tight bounds on the parameters

Tobias Grosser tobias at grosser.es
Wed Feb 18 12:17:01 PST 2015


Hi Johannes,

this patch LGTM besides two minor comments:

1. The LLVM language reference says "The range is allowed to wrap."

In case the lower bound is larger than the upper bound (e.g. [10, 5) we would add constraints p >= 10 && p < 5. However, this should rather be p >= 10 || p < 5.

2. Add a comment that this change exploits LLVM's range metadata to the commit message

Sebastian pointed out that from a look at the commit message or the test case it is not immediately clear where the information about the bounded range of p is derived from. It would be nice to point this out in the commit message.


http://reviews.llvm.org/D7579

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list