[PATCH] Use ".arch_extension" ARM directive to specify the additional CPU features

Eric Christopher echristo at gmail.com
Wed Feb 18 10:46:32 PST 2015


Couple of comments/questions:

a) Formatting, please run this through clang-format.
b) The attribute changes on the testcases, what's going on there?
c) If the krait always has hardware divide why both conditionals after?
d) It seems that the .cpu directive for the krait cpu is orthogonal to the arch_extension part of this patch.
e) It doesn't seem that the arch_extension stuff is wired into the object emitter? What is supposed to happen there?

-eric


http://reviews.llvm.org/D7316

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list