[PATCH] [mips][microMIPS] Implement JALX instruction

Daniel Sanders daniel.sanders at imgtec.com
Wed Feb 18 06:21:30 PST 2015


================
Comment at: lib/Target/Mips/MipsInstrInfo.td:1213-1215
@@ -1212,4 +1212,5 @@
 
 // FIXME: JALX really requires either MIPS16 or microMIPS in addition to MIPS32.
-def JALX  : JumpLink<"jalx", calltarget>, FJ<0x1D>, ISA_MIPS32_NOT_32R6_64R6;
+def JALX  : MMRel, JumpLink<"jalx", calltarget>, FJ<0x1D>,
+            ISA_MIPS32_NOT_32R6_64R6;
 def BGEZAL : MMRel, BGEZAL_FT<"bgezal", brtarget, GPR32Opnd>, BGEZAL_FM<0x11>,
----------------
jkolek wrote:
> dsanders wrote:
> > Could we fix this fixme comment? An either/or feature bit (e.g. FeatureMips3_32) would do the trick.
> We have tried to assemble JALX with GAS and it does generate valid mips32 JALX opcode without -mmicromips or -mips16 command line options. To have same behaviour as GCC current implementation is sufficient, and comment can be removed.
That makes sense to me. Thanks

http://reviews.llvm.org/D5047

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list