[PATCH] ELF: Move relocation predicates out of the context class.

Rui Ueyama ruiu at google.com
Tue Feb 17 14:30:58 PST 2015


Shankar,

Are you saying that a relocation type cannot be interpreted if we don't
have a prior knowledge what machine type the reference is? It is true that
relocation types are machine dependent, of course, but that's different
from what I'm trying to do here.

We are currently passing a reference to a linking context object to ask
"what this reference type is?" But as I wrote before the reference itself
has the machine type info, so we don't have to involve the linking context.
The function to get the reference type can be an independent function, or a
member function of the reference, but the linking context is a wrong place,
because it's not related to the context.


http://reviews.llvm.org/D7605

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list