[PATCH] [X86][FastISel] Teach how to select float-half conversion intrinsics.

Quentin Colombet qcolombet at apple.com
Tue Feb 17 13:02:56 PST 2015

Comment at: test/CodeGen/X86/fast-isel-float-half-convertion.ll:7
@@ +6,3 @@
+  %0 = call i16 @llvm.convert.to.fp16.f32(float %a)
+  ret i16 %0
andreadb wrote:
> qcolombet wrote:
> > Could you add tests with doubles?
> > 
> > I may be wrong but I thought the intrinsic allows any floating type.
> Right, the intrinsic allows any floating point type.
> What if I add those tests into a separate test file maybe an XFAIL test)?
> My concern is that if I add extra tests for doubles in this same file, then the test will start failing because of flag -fast-isel-abort. What do you think? 
Good point.

Sounds good to me.



More information about the llvm-commits mailing list