[PATCH] [X86][FastIsel] Teach how to select scalar integer to float/double conversions.

Quentin Colombet qcolombet at apple.com
Tue Feb 17 10:48:46 PST 2015


Thanks Andrea!

LGTM with Juergen’s suggestion. I believe this is not needed for correctness, but it is definitely cleaner!

Cheers,
-Quentin


================
Comment at: test/CodeGen/X86/fast-isel-int-float-conversion.ll:7
@@ +6,3 @@
+; ALL-LABEL: int_to_double_rr:
+; SSE2: cvtsi2sdl %edi, %xmm0
+; AVX: vcvtsi2sdl %edi, %xmm0, %xmm0
----------------
You could still keep the SSE2-NOT with vcvt stuff if you want to be sure :).

http://reviews.llvm.org/D7698

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list