[PATCH] [LoopAccesses] Make VectorizerParams global

Adam Nemet anemet at apple.com
Tue Feb 17 10:21:36 PST 2015


================
Comment at: include/llvm/Transforms/Utils/VectorUtils.h:205
@@ +204,3 @@
+/// Loop Access Analysis.
+struct VectorizerParams {
+  /// \brief Maximum SIMD width.
----------------
anemet wrote:
> hfinkel wrote:
> > I'd prefer you leave this in include/llvm/Analysis/LoopAccessAnalysis.h, it does not really fit with the theme of this file (which is transformation-independent utilities dealing with vector intrinsics, etc.). Leaving it in LAA.h puts it near its user, which I like better.
> Sure thing.
Hal, quick question.  Do you have a preference whether you want to keep VectorizerParams local to LoopAccessInfo or move it to the top level?  In order to access the static fields, you'd now have to write the lengthy:

LoopAccessInfo::VectorizerParams::VectorizationFactor

http://reviews.llvm.org/D7680

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list