[llvm] r229502 - I believe we no longer require LLVM_HAS_INITIALIZER_LISTS; it's supported in MSVC 2013 and GCC. Added a trivial test to ensure the ArrayRef initializer list constructor is called and behaves as expected.

Aaron Ballman aaron at aaronballman.com
Tue Feb 17 08:59:14 PST 2015


On Tue, Feb 17, 2015 at 11:54 AM, Chandler Carruth <chandlerc at google.com> wrote:
>
> On Tue, Feb 17, 2015 at 7:37 AM, Aaron Ballman <aaron at aaronballman.com>
> wrote:
>>
>> +TEST(ArrayRefTest, InitializerList) {
>> +  ArrayRef<int> A{ 0, 1, 2, 3, 4 };
>
>
> Please use the = { ... }; syntax instead. I'm strongly opposed to using {}
> for direct initialization in essentially every case. Even when it's the only
> way to make a construct compile, I would rather use a different construct.

Thanks! I've changed this in r229512

~Aaron



More information about the llvm-commits mailing list