[PATCH] Modularizing LICM

[hfinkel at anl.gov]

REPOSITORY
  rL LLVM

================
Comment at: include/llvm/Transforms/Utils/LoopUtils.h:85
@@ +84,3 @@
+/// iteration. Takes DomTreeNode, AliasAnalysis, LoopInfo, DominatorTree, 
+/// DataLayout, TargetLibraryInfo, Loop, AliasSet information for the input loop
+/// and loop safety information as argument. It returns changed status. 
----------------
Please improve the description of what needs to be in the AliasSetTracker. Should it contain all memory accesses in the loop?


================
Comment at: include/llvm/Transforms/Utils/LoopUtils.h:110
@@ +109,3 @@
+/// argument. It returns changed status.
+bool promoteAliasSet(AliasSet &, SmallVectorImpl<BasicBlock*> &,
+                     SmallVectorImpl<Instruction*> &,
----------------
This function seems poorly named given its description as, "Try to promote memory values to scalars by sinking stores out of  the loop and moving loads to before the loop." Maybe promoteLoopAccessesToScalars?

http://reviews.llvm.org/D7291

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/