[PATCH] Teach llvm-readobj to dump symbol records from a DEBUG_SYMBOL_SUBSECTION section.

Timur Iskhodzhanov timurrrr at google.com
Tue Feb 17 04:28:01 PST 2015


================
Comment at: tools/llvm-readobj/COFFDumper.cpp:509
@@ -508,3 +508,3 @@
       StringRef Contents = Data.substr(Offset, PayloadSize);
       W.printBinaryBlock("Contents", Contents);
 
----------------
I meant we might want to put the
  W.printBinaryBlock("Contents", Contents);
line under a `CodeViewSomethingUnknownSomething` condition.

================
Comment at: tools/llvm-readobj/llvm-readobj.h:40
@@ -40,1 +39,3 @@
+  extern llvm::cl::opt<bool> CodeView;
+  extern llvm::cl::opt<bool> CodeViewUnknownSymbols;
   extern llvm::cl::opt<bool> ARMAttributes;
----------------
might want to generalize to "CodeViewDumpUnknownRecords` or something.

http://reviews.llvm.org/D7664

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list