[PATCH] Modularizing LICM

[Nema, Ashutosh]

> We can move them, but please do that in a separate patch. 
> The current scheme seems to be to have: lib/Transforms/Scalar/LICMPass.cpp and lib/Transforms/Utils/LICM.cpp.

Sure, will do it in separate patch.

Regards,
Ashutosh

-----Original Message-----
From: hfinkel at anl.gov [mailto:hfinkel at anl.gov] 
Sent: Tuesday, February 17, 2015 3:03 PM
To: Nema, Ashutosh; listmail at philipreames.com; bruno.cardoso at gmail.com; hfinkel at anl.gov
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] Modularizing LICM

In http://reviews.llvm.org/D7291#124681, @ashutosh.nema wrote:

> Thanks Hal.
>  Sure I'll move ' LICMSafetyInfo' to a header file.
>  I'm planning to keep it in "LoopUtils.h".
>
> Also can I move exposed functions(i.e. HoistRegion, SinkRegion, 
> PromoteAliasSets & computeLICMSafetyInfo)  and dependent routines to a separate file under utils i.e. "lib/Transforms/Utils/LICMCore.cpp" ?


We can move them, but please do that in a separate patch. The current scheme seems to be to have: lib/Transforms/Scalar/LICMPass.cpp and lib/Transforms/Utils/LICM.cpp.

> Regards,

> Ashutosh



REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7291

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/