[PATCH] [lld][ELF] Demangle: don't expose raw info when getter is available.

Davide Italiano davide at freebsd.org
Mon Feb 16 21:22:03 PST 2015


Hi shankar.easwaran,

Shankar, I like to use getter/setter everywhere better. If you disagree, I'll withdrawn the revision.

REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7693

Files:
  lib/ReaderWriter/ELF/ELFLinkingContext.cpp
  lib/ReaderWriter/MachO/MachOLinkingContext.cpp

Index: lib/ReaderWriter/ELF/ELFLinkingContext.cpp
===================================================================
--- lib/ReaderWriter/ELF/ELFLinkingContext.cpp
+++ lib/ReaderWriter/ELF/ELFLinkingContext.cpp
@@ -232,7 +232,7 @@
 }

 std::string ELFLinkingContext::demangle(StringRef symbolName) const {
-  if (!_demangle)
+  if (!demangleSymbols())
     return symbolName;

   // Only try to demangle symbols that look like C++ symbols
Index: lib/ReaderWriter/MachO/MachOLinkingContext.cpp
===================================================================
--- lib/ReaderWriter/MachO/MachOLinkingContext.cpp
+++ lib/ReaderWriter/MachO/MachOLinkingContext.cpp
@@ -791,7 +791,7 @@

 std::string MachOLinkingContext::demangle(StringRef symbolName) const {
   // Only try to demangle symbols if -demangle on command line
-  if (!_demangle)
+  if (!demangleSymbols())
     return symbolName;

   // Only try to demangle symbols that look like C++ symbols

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7693.20066.patch
Type: text/x-patch
Size: 955 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150217/32963e6f/attachment.bin>


More information about the llvm-commits mailing list