[PATCH] [Review Request] Numbering SDNode to discard SmallPtrSet in selection DAG

[Mehdi AMINI]

REPOSITORY
  rL LLVM

================
Comment at: include/llvm/CodeGen/SelectionDAGNodes.h:964
@@ -945,3 +963,3 @@
 #else
-  explicit HandleSDNode(SDValue X)
+  explicit HandleSDNode(SDContext *ownerDAG, SDValue X)
 #endif
----------------
Minor comment if you update this revision: variable should start with an uppercase: s/ownerDAG/OwnerDAG/

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:900
@@ -898,2 +899,3 @@
 void SelectionDAG::clear() {
+  SDNodeCount = 1;
   allnodes_clear();
----------------
Why 1? I would have expected 0 here?

================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:549
@@ -547,2 +548,3 @@
       continue;
-
+    } else {
+      VisitedNodes[N->SeqPos] = true;
----------------
No need for else here after continue.

http://reviews.llvm.org/D1129

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/