[PATCH] AArch64: Safely handle the incoming sret call argument.

Tim Northover t.p.northover at gmail.com
Mon Feb 16 07:38:47 PST 2015

Hi Andy,

On 13 February 2015 at 17:36, Andrew Trick <atrick at apple.com> wrote:
>> This adds a safe interface to the machine independent InputArg
>> struct for accessing the index of the original (IR-level)
>> argument. When a non-native return type is lowered, we generate
>> the hidden machine-level sret argument on-the-fly. Before this
>> fix, we were representing this argument as OrigArgIndex == 0,
>> which is an outright lie. In particular this crashed in the
>> AArch64 backend where we actually try to access the type of the
>> original argument.

This looks good to me. We need some kind of sentinel or flag, and
UINT_MAX is as good as anything.



More information about the llvm-commits mailing list