[PATCH] [X86] Try to combine vector anyext + and into a vector zext

Michael Kuperstein michael.m.kuperstein at intel.com
Mon Feb 16 07:28:22 PST 2015


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:24668-24669
@@ +24667,4 @@
+      N0.getOperand(0).getOpcode() == ISD::VECTOR_SHUFFLE &&
+      (N1.getOpcode() == ISD::BUILD_VECTOR ||
+       N1.getOpcode() == ISD::BITCAST)) {
+
----------------
mkuper wrote:
> andreadb wrote:
> > I think you can remove these two checks.
> > Your algorithm already checks (between line 24682 and 24686) that N1 is a build_vector or a bitcast of a build_vector.
> Right, either the check here or the second check (in 24685) is redundant.
> I'd rather remove the check in 24685, to be honest.
Never mind, ignore this, you're right.

http://reviews.llvm.org/D7666

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list