[PATCH] Modularizing LICM

Ashutosh Nema ashutosh.nema at amd.com
Mon Feb 16 03:31:56 PST 2015


Thanks Hal, Philip & Bruno for review.

Incorporated review comments.

Changes in this patch:

1. Introduced 'LICMSafetyInfo', earlier 'MayThrow' & 'HeaderMayThrow' was exposed outside. But now 'SinkRegion', 'HoistRegion' and 'PromoteAliasSet' will compute safety information.
2. Removed newly included headers in 'LoopUtils.h' Instead used forward declaration.
3. Corrected indentation issues.
4. Corrected comments to function by removing function names.
5. Earlier return status of 'PromoteAliasSet' was not getting used, corrected to set 'Changed'.

Please check updated changes, your suggestions and comments are welcome.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7291

Files:
  include/llvm/Transforms/Utils/LoopUtils.h
  lib/Transforms/Scalar/LICM.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7291.20012.patch
Type: text/x-patch
Size: 32988 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150216/be79650e/attachment.bin>


More information about the llvm-commits mailing list