[PATCH] Add a few basic tests for llvm-pdbdump

David Blaikie dblaikie at gmail.com
Sun Feb 15 16:45:44 PST 2015


Might be helpful to show the full (or at least abbreviated) output & explain what you're trying to test for/against - since I haven't actually seen the output of pdbdump, it's hard to tell what the tests would catch/avoid/etc.


================
Comment at: test/DebugInfo/PDB/Inputs/symbolformat-fpo.cpp:6
@@ +5,1 @@
+}
\ No newline at end of file

----------------
add the missing newline here

================
Comment at: test/DebugInfo/PDB/Inputs/symbolformat.cpp:1
@@ +1,2 @@
+#include <stdio.h>
+
----------------
do you need stdio here? It'd be best to have standalone examples as much as possible.

http://reviews.llvm.org/D7656

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list