[PATCH] R600/SI: Misc fixes for special division instructions

Tom Stellard tom at stellard.net
Fri Feb 13 17:51:17 PST 2015


On Fri, Feb 13, 2015 at 02:13:44PM -0800, Matt Arsenault wrote:
> 
> > On Feb 13, 2015, at 12:24 PM, Matt Arsenault <arsenm2 at gmail.com> wrote:
> > 
> > 
> >> On Feb 13, 2015, at 12:00 PM, Tom Stellard <tom at stellard.net <mailto:tom at stellard.net>> wrote:
> >> 
> >> If you change this, you will also need to change all the operand names
> >> for VOP3 instructions from dst->vdst or else encoding may break.
> >> 
> >> -Tom
> > 
> > I don’t think so since these are independently defined formats. However, the docs also call this vdst in the other formats, so for consistency they should probably also be renamed. This and the others can be renamed later
> 
> 
> Updated patches


LGTM.




More information about the llvm-commits mailing list