[PATCH] [lld] Revive standalone CMake build

Greg Fitzgerald garious at gmail.com
Fri Feb 13 15:48:31 PST 2015


REPOSITORY
  rL LLVM

================
Comment at: CMakeLists.txt:54
@@ -5,2 +53,3 @@
+endif()
 
 set(LLD_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
----------------
shankarke wrote:
> Does other projects too have a standalone build, I thought it was completely removed. If this is being revived should this be done for all projects ?
> 
> Please wait for Bigcheese / Nick whether we want to bring this in.
Yes, all other llvm projects have a standalone CMake builds.

================
Comment at: cmake/config-ix.cmake:6
@@ +5,2 @@
+int main() { return 0; }
+" HAVE_CXXABI_H)
----------------
shankarke wrote:
> garious wrote:
> > shankarke wrote:
> > > why is this being reimplemented ?
> > Because the LLVM install directory does not offer this functionality.
> should this be then added to the LLVM install directory then ? we need to keep mirroring these changes from llvm if there is a change, I think it woul d be hard to maintain. 
I have no strong opinion on this.  I see your point, but also think the LLVM repo should minimize its public interface.  My preference is to hold off on adding this to LLVM's install directory until the duplication causes a little pain.  I can imagine this particular code living a long time without causing any.

http://reviews.llvm.org/D7625

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list