[PATCH] Beginning of alloca implementation for Mips fast-isel

reed kotler rkotler at mips.com
Fri Feb 13 15:47:35 PST 2015


Hi Eric,

I appreciate you taking the time to do the review but please make your 
comments using phabricator using the phabricator online
interface so that you can put them right where the source goes.

When you make one block it's hard to track them and in this case when I 
responded to the email, it threw
away my response to your comments from the phabricator.

Are your comments all formatting issues?

In general we are using clang-format -i for all new Mips code.

Are you looking at this patch in Phabricator so you can see how the code 
really looks when the patch is applied?

Reed

On 02/13/2015 03:34 PM, Eric Christopher wrote:
> Unnecessary = "You shouldn't need to make this change"
> No = "You can't make this change"
>
> -eric
>
>
> http://reviews.llvm.org/D6426
>
> EMAIL PREFERENCES
>    http://reviews.llvm.org/settings/panel/emailpreferences/
>
>




More information about the llvm-commits mailing list