[PATCH] ELF: Move relocation predicates out of the context class.

Rui Ueyama ruiu at google.com
Fri Feb 13 11:17:29 PST 2015


But the relocation type is not architecture dependent, right? The
relocation itself knows what the relocation type of itself is. Maybe I can
make this member functions of relocation, but adding that predicates to
linking context object is not logically correct.

On Fri, Feb 13, 2015 at 8:03 AM, Simon Atanasyan <simon at atanasyan.com>
wrote:

> I think all target related code should be separated by LinkingContext,
> TargetHandler etc descendant classes. If moving relocation predicates to
> the TargetHandler descendants makes the code clear, it is a good idea.
>
>
> http://reviews.llvm.org/D7605
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150213/57d9de17/attachment.html>


More information about the llvm-commits mailing list