[PATCH] [mips] Use isa<> instead of dyn_cast<> with unused value. NFC.

David Blaikie dblaikie at gmail.com
Fri Feb 13 10:26:02 PST 2015


LGTM, please commit.

On Fri, Feb 13, 2015 at 8:57 AM, Vasileios Kalintiris <
Vasileios.Kalintiris at imgtec.com> wrote:

> Hi dsanders,
>
> http://reviews.llvm.org/D7615
>
> Files:
>   lib/Target/Mips/MipsSEISelLowering.cpp
>
> Index: lib/Target/Mips/MipsSEISelLowering.cpp
> ===================================================================
> --- lib/Target/Mips/MipsSEISelLowering.cpp
> +++ lib/Target/Mips/MipsSEISelLowering.cpp
> @@ -2291,9 +2291,9 @@
>  static bool isConstantOrUndef(const SDValue Op) {
>    if (Op->getOpcode() == ISD::UNDEF)
>      return true;
> -  if (dyn_cast<ConstantSDNode>(Op))
> +  if (isa<ConstantSDNode>(Op))
>      return true;
> -  if (dyn_cast<ConstantFPSDNode>(Op))
> +  if (isa<ConstantFPSDNode>(Op))
>      return true;
>    return false;
>  }
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150213/d8883031/attachment.html>


More information about the llvm-commits mailing list