[PATCH] ELF: Move relocation predicates out of the context class.

Shankar Kalpathi Easwaran shankarke at gmail.com
Fri Feb 13 07:54:56 PST 2015


other reasons I dont like this design is

- IMO, this would become hard to maintain and not clean.
- Checks all architecture specific relocations in one common place, it would hurt performance.
  - For example, if x86_64 is the current link type, the case checks for all other architectures, and this happens for every relocation.

A good alternative is to move this code to the TargetHandler, as its specific to only that target.

What do you think ? Simon / Bigcheese ?


http://reviews.llvm.org/D7605

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list