[PATCH] Change representation of member function pointers for MIPS targets

Daniel Sanders daniel.sanders at imgtec.com
Fri Feb 13 07:24:48 PST 2015


I'm not particularly knowledgeable about C++ ABI's but I have compared the gcc and clang output and I agree that this change makes the representation the same as gcc's. I tested MIPS32r2 and microMIPS. On that basis, LGTM apart from TargetCXXABI::tryParse() as noted below.


================
Comment at: lib/Basic/TargetInfo.cpp:658
@@ -657,2 +657,3 @@
     .Case("microsoft", Microsoft)
+    .Case("arm", GenericMIPS)
     .Default(unknown);
----------------
Shouldn't "arm" be "mips" here?

http://reviews.llvm.org/D7148

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list