[PATCH] ELF: Move relocation predicates out of the context class.

Simon Atanasyan simon at atanasyan.com
Fri Feb 13 03:56:24 PST 2015


I am sorry, but I do not see how this patch helps to reduce code duplication. I think commit http://reviews.llvm.org/rL222313 is a good example of sharing a common ELF code among targets. In that case Shankar found the code applicable to all ELF target and relocated them to the base class `DefaultLayout`. In this patch we just replace virtual functions by switch cases.


http://reviews.llvm.org/D7605

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list