[PATCH] A bit-tracking DCE Pass

David Majnemer david.majnemer at gmail.com
Thu Feb 12 22:06:00 PST 2015


================
Comment at: lib/Transforms/Scalar/BDCE.cpp:144
@@ +143,3 @@
+         OI != OE; ++OI)
+      if (Instruction* I = dyn_cast<Instruction>(OI)) {
+        if (IntegerType *IT = dyn_cast<IntegerType>(I->getType())) {
----------------
hfinkel wrote:
> majnemer wrote:
> > Pointer on the right hand side.
> I don't understand. The RHS has OI, which is an Instruction::op_iterator, which is a Use*.
I was referring to your `Instruction* I`, I think it should be `Instruction *I`.

http://reviews.llvm.org/D7531

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list