[llvm] r229063 - [InstCombine] Fix a bug when combining `icmp` from `ptrtoint`

[Michael Liao]

LLVM 3.5 has the same issue.

- Michael


On Thu, 2015-02-12 at 21:34 -0800, Chandler Carruth wrote:
> 
> On Thu, Feb 12, 2015 at 8:51 PM, Michael Liao <michael.liao at intel.com>
> wrote:
>         Author: hliao
>         Date: Thu Feb 12 22:51:26 2015
>         New Revision: 229063
>         
>         URL: http://llvm.org/viewvc/llvm-project?rev=229063&view=rev
>         Log:
>         [InstCombine] Fix a bug when combining `icmp` from `ptrtoint`
>         
>         - First, there's a crash when we try to combine that pointers
>         into `icmp`
>           directly by creating a `bitcast`, which is invalid if that
>         two pointers are
>           from different address spaces.
>         
>         - It's not always appropriate to cast one pointer to another
>         if they are from
>           different address spaces as that is not no-op cast. Instead,
>         we only combine
>           `icmp` from `ptrtoint` if that two pointers are of the same
>         address space.
> 
> Are these regressions from 3.5?