[lld] r229055 - Remove unused parameters.

Rui Ueyama ruiu at google.com
Thu Feb 12 20:02:55 PST 2015


Author: ruiu
Date: Thu Feb 12 22:02:55 2015
New Revision: 229055

URL: http://llvm.org/viewvc/llvm-project?rev=229055&view=rev
Log:
Remove unused parameters.

Modified:
    lld/trunk/include/lld/ReaderWriter/ELFLinkingContext.h
    lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64LinkingContext.h
    lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h
    lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonLinkingContext.h
    lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.cpp
    lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.h
    lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64LinkingContext.h

Modified: lld/trunk/include/lld/ReaderWriter/ELFLinkingContext.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/ReaderWriter/ELFLinkingContext.h?rev=229055&r1=229054&r2=229055&view=diff
==============================================================================
--- lld/trunk/include/lld/ReaderWriter/ELFLinkingContext.h (original)
+++ lld/trunk/include/lld/ReaderWriter/ELFLinkingContext.h Thu Feb 12 22:02:55 2015
@@ -94,10 +94,7 @@ public:
   /// referenced by the DT_RELA{,ENT,SZ} entries in the dynamic table.
   /// Relocations that return true will be added to the dynamic relocation
   /// table.
-  virtual bool isDynamicRelocation(const DefinedAtom &,
-                                   const Reference &) const {
-    return false;
-  }
+  virtual bool isDynamicRelocation(const Reference &) const { return false; }
 
   /// \brief Is this a copy relocation?
   ///
@@ -129,9 +126,7 @@ public:
   /// by the DT_{JMPREL,PLTRELSZ} entries in the dynamic table.
   /// Relocations that return true will be added to the dynamic plt relocation
   /// table.
-  virtual bool isPLTRelocation(const DefinedAtom &, const Reference &) const {
-    return false;
-  }
+  virtual bool isPLTRelocation(const Reference &) const { return false; }
 
   /// \brief The path to the dynamic interpreter
   virtual StringRef getDefaultInterpreter() const {

Modified: lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64LinkingContext.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64LinkingContext.h?rev=229055&r1=229054&r2=229055&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64LinkingContext.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64LinkingContext.h Thu Feb 12 22:02:55 2015
@@ -35,8 +35,7 @@ public:
     return _baseAddress;
   }
 
-  bool isDynamicRelocation(const DefinedAtom &,
-                           const Reference &r) const override {
+  bool isDynamicRelocation(const Reference &r) const override {
     if (r.kindNamespace() != Reference::KindNamespace::ELF)
       return false;
     assert(r.kindArch() == Reference::KindArch::AArch64);
@@ -64,8 +63,7 @@ public:
     return false;
   }
 
-  bool isPLTRelocation(const DefinedAtom &,
-                               const Reference &r) const override {
+  bool isPLTRelocation(const Reference &r) const override {
     if (r.kindNamespace() != Reference::KindNamespace::ELF)
       return false;
     assert(r.kindArch() == Reference::KindArch::AArch64);

Modified: lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h?rev=229055&r1=229054&r2=229055&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/DefaultLayout.h Thu Feb 12 22:02:55 2015
@@ -571,10 +571,10 @@ ErrorOr<const lld::AtomLayout &> Default
     // Add runtime relocations to the .rela section.
     for (const auto &reloc : *definedAtom) {
       bool isLocalReloc = true;
-      if (_context.isDynamicRelocation(*definedAtom, *reloc)) {
+      if (_context.isDynamicRelocation(*reloc)) {
         getDynamicRelocationTable()->addRelocation(*definedAtom, *reloc);
         isLocalReloc = false;
-      } else if (_context.isPLTRelocation(*definedAtom, *reloc)) {
+      } else if (_context.isPLTRelocation(*reloc)) {
         getPLTRelocationTable()->addRelocation(*definedAtom, *reloc);
         isLocalReloc = false;
       }

Modified: lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonLinkingContext.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonLinkingContext.h?rev=229055&r1=229054&r2=229055&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonLinkingContext.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Hexagon/HexagonLinkingContext.h Thu Feb 12 22:02:55 2015
@@ -26,8 +26,7 @@ public:
 
   void addPasses(PassManager &) override;
 
-  bool isDynamicRelocation(const DefinedAtom &,
-                           const Reference &r) const override {
+  bool isDynamicRelocation(const Reference &r) const override {
     if (r.kindNamespace() != Reference::KindNamespace::ELF)
       return false;
     switch (r.kindValue()) {
@@ -39,7 +38,7 @@ public:
     }
   }
 
-  bool isPLTRelocation(const DefinedAtom &, const Reference &r) const override {
+  bool isPLTRelocation(const Reference &r) const override {
     if (r.kindNamespace() != Reference::KindNamespace::ELF)
       return false;
     switch (r.kindValue()) {

Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.cpp?rev=229055&r1=229054&r2=229055&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.cpp Thu Feb 12 22:02:55 2015
@@ -74,8 +74,7 @@ void MipsLinkingContext::addPasses(PassM
   pm.add(llvm::make_unique<elf::MipsCtorsOrderPass>());
 }
 
-bool MipsLinkingContext::isDynamicRelocation(const DefinedAtom &,
-                                             const Reference &r) const {
+bool MipsLinkingContext::isDynamicRelocation(const Reference &r) const {
   if (r.kindNamespace() != Reference::KindNamespace::ELF)
     return false;
   assert(r.kindArch() == Reference::KindArch::Mips);
@@ -100,8 +99,7 @@ bool MipsLinkingContext::isCopyRelocatio
   return false;
 }
 
-bool MipsLinkingContext::isPLTRelocation(const DefinedAtom &,
-                                         const Reference &r) const {
+bool MipsLinkingContext::isPLTRelocation(const Reference &r) const {
   if (r.kindNamespace() != Reference::KindNamespace::ELF)
     return false;
   assert(r.kindArch() == Reference::KindArch::Mips);

Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.h?rev=229055&r1=229054&r2=229055&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsLinkingContext.h Thu Feb 12 22:02:55 2015
@@ -50,10 +50,9 @@ public:
   StringRef getDefaultInterpreter() const override;
   void addPasses(PassManager &pm) override;
   bool isRelaOutputFormat() const override { return false; }
-  bool isDynamicRelocation(const DefinedAtom &,
-                           const Reference &r) const override;
+  bool isDynamicRelocation(const Reference &r) const override;
   bool isCopyRelocation(const Reference &r) const override;
-  bool isPLTRelocation(const DefinedAtom &, const Reference &r) const override;
+  bool isPLTRelocation(const Reference &r) const override;
 
 private:
   MipsELFFlagsMerger _flagsMerger;

Modified: lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64LinkingContext.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64LinkingContext.h?rev=229055&r1=229054&r2=229055&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64LinkingContext.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64LinkingContext.h Thu Feb 12 22:02:55 2015
@@ -37,8 +37,7 @@ public:
     return _baseAddress;
   }
 
-  bool isDynamicRelocation(const DefinedAtom &,
-                           const Reference &r) const override {
+  bool isDynamicRelocation(const Reference &r) const override {
     if (r.kindNamespace() != Reference::KindNamespace::ELF)
       return false;
     assert(r.kindArch() == Reference::KindArch::x86_64);
@@ -63,8 +62,7 @@ public:
     return false;
   }
 
-  virtual bool isPLTRelocation(const DefinedAtom &,
-                               const Reference &r) const override {
+  virtual bool isPLTRelocation(const Reference &r) const override {
     if (r.kindNamespace() != Reference::KindNamespace::ELF)
       return false;
     assert(r.kindArch() == Reference::KindArch::x86_64);





More information about the llvm-commits mailing list