[llvm] r228979 - X86: Don't crash if we can't decode the pshufb mask

Chandler Carruth chandlerc at google.com
Thu Feb 12 16:37:35 PST 2015


On Thu, Feb 12, 2015 at 3:26 PM, David Majnemer <david.majnemer at gmail.com>
wrote:

> Author: majnemer
> Date: Thu Feb 12 17:26:26 2015
> New Revision: 228979
>
> URL: http://llvm.org/viewvc/llvm-project?rev=228979&view=rev
> Log:
> X86: Don't crash if we can't decode the pshufb mask
>
> Constant pool entries are uniqued by their contents regardless of their
> type.  This means that a pshufb can have a shuffle mask which isn't a
> simple array of bytes.
>

While we clearly should not crash, it'd be nice to decode these constant
pool entries. Maybe leave a fixme or something so that at some point we
come back and add decoding support for weird entries?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150212/9852afbb/attachment.html>


More information about the llvm-commits mailing list