[PATCH] Call sys::fs::remove for options::OT_DISABLE

[H.J. Lu]

On Thu, Feb 12, 2015 at 7:09 AM, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
> On 12 February 2015 at 09:25, H.J. Lu <hjl.tools at gmail.com> wrote:
>> On Thu, Feb 12, 2015 at 6:15 AM, Rafael Espíndola
>> <rafael.espindola at gmail.com> wrote:
>>> I assume this shows up with bfd ld.
>>>
>>> Is this already covered by some test when run with bfd ld instead of gold?
>>
>> test/tools/gold/emit-llvm.ll has
>>
>> ; RUN: rm -f %t4.o
>> ; RUN: ld -plugin %llvmshlibdir/LLVMgold.so \
>> ; RUN:     -m elf_x86_64 --plugin-opt=disable-output \
>> ; RUN:    -shared %t.o -o %t4.o
>> ; RUN: not test -a %t4.o
>>
>> It fails with ld.
>
> OK. LGTM with a comment saying that bfd create the output file early.
>

Here is the updated patch with a comment. Michael, can you
check it in for me?

Thanks.


-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Call-sys-fs-remove-for-options-OT_DISABLE.patch
Type: text/x-patch
Size: 1134 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150212/6d5e9755/attachment.bin>