[llvm] r228842 - Gold-plugin: Broaden scope of get/release_input_file to scope of Module.

[Rafael Espíndola]

On 11 February 2015 at 17:56, Hans Wennborg <hans at chromium.org> wrote:
> On Wed, Feb 11, 2015 at 8:12 AM, Jan Wen Voung <jvoung at google.com> wrote:
>> Author: jvoung
>> Date: Wed Feb 11 10:12:50 2015
>> New Revision: 228842
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=228842&view=rev
>> Log:
>> Gold-plugin: Broaden scope of get/release_input_file to scope of Module.
>>
>> Summary:
>> Move calls to get_input_file and release_input_file out of
>> getModuleForFile(). Otherwise release_input_file may end up
>> unmapping a view of the file while the view is still being
>> used by the Module (on 32-bit hosts).
>>
>> Fix for PR22482.
>>
>> Test Plan: Add test using --no-map-whole-files.
>
> Rafael, should we merge this to 3.6? The PR was on my list, but I
> can't judge how serious this issue is vs. the safety of the patch.

The patch is extremely safe, so it is probably a good merge candidate.

Cheers,
Rafael