[PATCH] [LoopRerolling] Be more forgiving with instruction order.

hfinkel at anl.gov hfinkel at anl.gov
Wed Feb 11 13:34:26 PST 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/Transforms/Scalar/LoopRerollPass.cpp:1074
@@ +1073,3 @@
+      if (!BaseInst->isSameOperationAs(RootInst)) {
+        // Last chance saloon. We don't try and solve the full isomorphism problem,
+        // but try and at least catch the case where two instructions *of different
----------------
Lines here are too long?

================
Comment at: lib/Transforms/Scalar/LoopRerollPass.cpp:1083
@@ +1082,3 @@
+        auto TryIt = RootIt;
+        while (TryIt != Uses.end() &&
+               !BaseInst->isSameOperationAs(TryIt->first)) {
----------------
This is potentially N^2 in the size of Uses? We should probably cut this off at some point.

http://reviews.llvm.org/D7562

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list