[PATCH] SelectionDAG: fold (fp_to_u/sint (u/sint_to_fp val)) when possible

Fiona Glaser fglaser at apple.com
Wed Feb 11 11:09:02 PST 2015


Okay, I’ve implemented a cleaner and nicer InstCombine per suggestions.

The two things I remain unsure about:

1) is the use of replacealluseswith correct? Should I be using it elsewhere?

2) should the DAG combine be enhanced too to match the InstCombine? That is, are we allowed to take advantage of undefined behavior in the DAGCombine, or is that bad because the target may shuffle around the DAG in ways that relies on target-specific behavior?

Fiona

-------------- next part --------------
A non-text attachment was scrubbed...
Name: floatcvtfold.diff
Type: application/octet-stream
Size: 14026 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150211/b0f2e5ab/attachment.obj>


More information about the llvm-commits mailing list