[PATCH] [lld] findAbsoluteAtom asserts the atom is really existing

Davide Italiano davide at freebsd.org
Wed Feb 11 00:40:18 PST 2015


Your use case sounds reasonable and, maybe, we should move the check in the caller.  I would like to hear what other people think, in particular Shankar who originally introduced this code. Another possibility to avoid introducing getAbsoluteAtom() might be that of passing a boolean flag to the existing function to change the behaviour (assert/not assert). I'm not sure I like this a lot, though.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7549

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list