[PATCH] Build procedure for lldb project with cmake/ninja

Siva Chandra sivachandra at google.com
Wed Feb 11 00:03:14 PST 2015


Sorry for revisiting. Just a couple of things which are probably good to be fixed, but not required/important.


================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:258
@@ +257,3 @@
+            extra_configure_args=[],
+            env={},
+            *args,
----------------
Default args to Python functions should not be empty lists or empty dicts. It does not matter in this case as this function is called only once. So, its up to you if you want to fix.

See: http://stackoverflow.com/questions/9887180/the-value-of-an-empty-list-in-function-parameter-example-here

================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:320
@@ +319,3 @@
+		   "-DCMAKE_CXX_COMPILER=clang++",
+  		   "-DCMAKE_BUILD_TYPE=Debug",
+                   WithProperties("../%s" %llvm_srcdir),
----------------
This should probably be in extra_configure_args.

http://reviews.llvm.org/D7521

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list